MatthiesenXYZ
/
astro-hashnode
1
0
Fork 0
Code Issues Pull Requests Packages Releases 9 Activity

feat: ✨ Chore: Update AIK and add ViewTransition support #13

Merged
create-issue-branch[bot] merged 6 commits from issue-12-Chore_Update_AIK into main 2024-03-12 22:15:03 +00:00
Conversation 7 Commits 6 Files Changed 11 +224 -368
create-issue-branch[bot] commented 2024-03-12 20:37:30 +00:00 (Migrated from github.com)
Copy Link
Original issue description

Update astro-integration-kit to v0.6

closes #12

<details> <summary><b>Original issue description</b></summary> Update `astro-integration-kit` to v0.6 </details> closes #12
vercel[bot] commented 2024-03-12 20:37:32 +00:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-hashnode-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 9:46pm
[vc]: #gtXAOQldp2/f98zzzHXmlJFjhlNRXU7cVMK+67ngS9k=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJhc3Ryby1oYXNobm9kZS1wbGF5Z3JvdW5kIiwiaW5zcGVjdG9yVXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL2FzdHJvLWdob3N0Y21zL2FzdHJvLWhhc2hub2RlLXBsYXlncm91bmQvR0ozQ0VZU1d6cUxiYVQ2U2o3RGZicDNRQkNZTSIsInByZXZpZXdVcmwiOiJhc3Ryby1oYXNobm9kZS1wbGF5Z3JvdW5kLWdpdC1pc3N1ZS0xMi1jaC1kZDMzYmUtYXN0cm8tZ2hvc3RjbXMudmVyY2VsLmFwcCIsIm5leHRDb21taXRTdGF0dXMiOiJERVBMT1lFRCIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJhc3Ryby1oYXNobm9kZS1wbGF5Z3JvdW5kLWdpdC1pc3N1ZS0xMi1jaC1kZDMzYmUtYXN0cm8tZ2hvc3RjbXMudmVyY2VsLmFwcCJ9LCJyb290RGlyZWN0b3J5IjoicGxheWdyb3VuZCJ9XX0= **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **astro-hashnode-playground** | ✅ Ready ([Inspect](https://vercel.com/astro-ghostcms/astro-hashnode-playground/GJ3CEYSWzqLbaT6Sj7Dfbp3QBCYM)) | [Visit Preview](https://vercel.live/open-feedback/astro-hashnode-playground-git-issue-12-ch-dd33be-astro-ghostcms.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/astro-hashnode-playground-git-issue-12-ch-dd33be-astro-ghostcms.vercel.app?via=pr-comment-feedback-link) | Mar 12, 2024 9:46pm |
changeset-bot[bot] commented 2024-03-12 20:37:34 +00:00 (Migrated from github.com)
Copy Link

🦋 Changeset detected

Latest commit: c1e6e7ede2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@matthiesenxyz/astro-hashnode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

### 🦋 Changeset detected Latest commit: c1e6e7ede2f1c7c567e0b7194bbf811f1855ca5e **The changes in this PR will be included in the next version bump.** <details><summary>This PR includes changesets to release 1 package</summary> | Name | Type | | ----------------------------- | ----- | | @matthiesenxyz/astro-hashnode | Patch | </details> Not sure what this means? [Click here to learn what changesets are](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md). [Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/MatthiesenXYZ/astro-hashnode/new/issue-12-Chore_Update_AIK?filename=.changeset/afraid-experts-lick.md&value=---%0A%22%40matthiesenxyz%2Fastro-hashnode%22%3A%20patch%0A%22playground%22%3A%20patch%0A---%0A%0Afeat%3A%20%E2%9C%A8%20Chore%3A%20Update%20%60AIK%60%20and%20add%20ViewTransition%20support%0A)
Adammatthiesen (Migrated from github.com) approved these changes 2024-03-12 21:20:52 +00:00
Adammatthiesen (Migrated from github.com) left a comment
Copy Link

Everything works!

Everything works!
jdtjenkins (Migrated from github.com) requested changes 2024-03-12 21:29:40 +00:00
package/README.md
jdtjenkins (Migrated from github.com) commented 2024-03-12 21:26:02 +00:00
Copy Link

There's probably a correct way of doing this semantically, but I would just have this option as viewTransitions: boolean and have it true by default

There's probably a correct way of doing this semantically, but I would just have this option as `viewTransitions: boolean` and have it true by default
package/src/layouts/Layout.astro
jdtjenkins (Migrated from github.com) commented 2024-03-12 21:28:04 +00:00
Copy Link

Yeah so if this option was positively worded you wouldn't need this ! here

Yeah so if this option was positively worded you wouldn't need this `!` here
package/src/layouts/Layout.astro
jdtjenkins (Migrated from github.com) commented 2024-03-12 21:29:36 +00:00
Copy Link

I'm not sure how pages work in this integration, but you may need some client directives too on some pages? Or is it up to the user to add those?

I'm not sure how pages work in this integration, but you may need some client directives too on some pages? Or is it up to the user to add those?
Adammatthiesen (Migrated from github.com) reviewed 2024-03-12 21:32:13 +00:00
package/README.md
Adammatthiesen (Migrated from github.com) commented 2024-03-12 21:32:13 +00:00
Copy Link

This is just showing the default as an example in the readme!

This is just showing the default as an example in the readme!
Adammatthiesen (Migrated from github.com) reviewed 2024-03-12 21:32:54 +00:00
package/src/layouts/Layout.astro
Adammatthiesen (Migrated from github.com) commented 2024-03-12 21:32:54 +00:00
Copy Link

The Example above shows the default option. Im inverting it to use down below since the default is false. as DO NOT disable ViewTransitions

The Example above shows the default option. Im inverting it to use down below since the default is false. as DO NOT disable ViewTransitions
Adammatthiesen (Migrated from github.com) reviewed 2024-03-12 21:33:53 +00:00
package/src/layouts/Layout.astro
Adammatthiesen (Migrated from github.com) commented 2024-03-12 21:33:53 +00:00
Copy Link

With this setup, its pulling data using graphql for any of the included pages so its not needed, if a user wanted to utilize this layout as their layout for other pages, they would be able to call whatever they need for their components specifically.

With this setup, its pulling data using graphql for any of the included pages so its not needed, if a user wanted to utilize this layout as their layout for other pages, they would be able to call whatever they need for their components specifically.
jdtjenkins (Migrated from github.com) reviewed 2024-03-12 21:37:43 +00:00
package/README.md
jdtjenkins (Migrated from github.com) commented 2024-03-12 21:37:25 +00:00
Copy Link

Ah I see! Even still I'd consider changing the name

Ah I see! Even still I'd consider changing the name
jdtjenkins (Migrated from github.com) approved these changes 2024-03-12 22:03:15 +00:00
jdtjenkins (Migrated from github.com) left a comment
Copy Link

Lookin gooooood

Lookin gooooood
Adammatthiesen commented 2024-03-12 22:08:04 +00:00 (Migrated from github.com)
Copy Link

!coauthor

!coauthor
Adammatthiesen commented 2024-03-12 22:10:58 +00:00 (Migrated from github.com)
Copy Link

'!coauthor'

'!coauthor'
Adammatthiesen commented 2024-03-12 22:11:38 +00:00 (Migrated from github.com)
Copy Link

!coauthor plz

!coauthor plz
Adammatthiesen commented 2024-03-12 22:12:28 +00:00 (Migrated from github.com)
Copy Link

!coauthor

!coauthor
github-actions[bot] commented 2024-03-12 22:12:39 +00:00 (Migrated from github.com)
Copy Link
Co-authored-by: Jacob Jenkins <7649031+jdtjenkins@users.noreply.github.com>
``` Co-authored-by: Jacob Jenkins <7649031+jdtjenkins@users.noreply.github.com> ```
Sign in to join this conversation.
Reviewers
No reviewers
Adammatthiesen
jdtjenkins
Labels
Clear labels   
bug

Something isn't working

  
dependencies

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MatthiesenXYZ/astro-hashnode#13
No description provided.
Delete Branch "issue-12-Chore_Update_AIK"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?