Chore: Upgrade to AIK & Massive Overhaul to internal processing #78

Merged
Adammatthiesen merged 46 commits from issue-77-Chore_Upgrade_to_utilize_AIK_&_Massive_integration_overhaul into main 2024-03-07 12:08:19 +00:00
7 changed files with 27 additions and 23 deletions
Showing only changes of commit b50e8882cc - Show all commits

View File

@ -177,10 +177,10 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Setup GhostCMS Theme Provider
localIntegration(
!options.ThemeProvider?.disableThemeProvider,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
!options.ThemeProvider.disableThemeProvider,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
"Theme Provider",
ghostThemeProvider({
theme: options.ThemeProvider?.theme,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
theme: options.ThemeProvider.theme,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
verbose,
})
);

florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```

View File

@ -6,7 +6,7 @@ import c from "picocolors";
jdtjenkins commented 2024-03-05 08:52:19 +00:00 (Migrated from github.com)
Review

You can probably resolve these paths instead of exporting it from your package?

You can probably resolve these paths instead of exporting it from your package?
jdtjenkins commented 2024-03-05 08:52:19 +00:00 (Migrated from github.com)
Review

You can probably resolve these paths instead of exporting it from your package?

You can probably resolve these paths instead of exporting it from your package?
Adammatthiesen commented 2024-03-05 09:00:35 +00:00 (Migrated from github.com)
Review

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...
Adammatthiesen commented 2024-03-05 09:00:35 +00:00 (Migrated from github.com)
Review

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...
jdtjenkins commented 2024-03-05 09:04:42 +00:00 (Migrated from github.com)
Review

They did in the old days before createResolver ❤️ it just can't be a virtual module

They did in the old days before `createResolver` ❤️ it just can't be a virtual module
jdtjenkins commented 2024-03-05 09:04:42 +00:00 (Migrated from github.com)
Review

They did in the old days before createResolver ❤️ it just can't be a virtual module

They did in the old days before `createResolver` ❤️ it just can't be a virtual module
Adammatthiesen commented 2024-03-05 09:30:57 +00:00 (Migrated from github.com)
Review

Yeah.... Thats updated now across the board... and those exports for /rss-routes and /open-graph are now moved to resolve()

Yeah.... Thats updated now across the board... and those exports for `/rss-routes` and `/open-graph` are now moved to `resolve()`
Adammatthiesen commented 2024-03-05 09:30:57 +00:00 (Migrated from github.com)
Review

Yeah.... Thats updated now across the board... and those exports for /rss-routes and /open-graph are now moved to resolve()

Yeah.... Thats updated now across the board... and those exports for `/rss-routes` and `/open-graph` are now moved to `resolve()`
export default defineIntegration({
name: "@matthiesenxyz/astro-ghostcms-rss",
optionsSchema: z.object({
verbose: z.boolean().optional().default(false),
jdtjenkins commented 2024-03-05 08:52:19 +00:00 (Migrated from github.com)
Review

You can probably resolve these paths instead of exporting it from your package?

You can probably resolve these paths instead of exporting it from your package?
Adammatthiesen commented 2024-03-05 09:00:35 +00:00 (Migrated from github.com)
Review

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...
jdtjenkins commented 2024-03-05 09:04:42 +00:00 (Migrated from github.com)
Review

They did in the old days before createResolver ❤️ it just can't be a virtual module

They did in the old days before `createResolver` ❤️ it just can't be a virtual module
Adammatthiesen commented 2024-03-05 09:30:57 +00:00 (Migrated from github.com)
Review

Yeah.... Thats updated now across the board... and those exports for /rss-routes and /open-graph are now moved to resolve()

Yeah.... Thats updated now across the board... and those exports for `/rss-routes` and `/open-graph` are now moved to `resolve()`
verbose: z.coerce.boolean().optional(),
jdtjenkins commented 2024-03-05 08:52:19 +00:00 (Migrated from github.com)
Review

You can probably resolve these paths instead of exporting it from your package?

You can probably resolve these paths instead of exporting it from your package?
Adammatthiesen commented 2024-03-05 09:00:35 +00:00 (Migrated from github.com)
Review

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...
jdtjenkins commented 2024-03-05 09:04:42 +00:00 (Migrated from github.com)
Review

They did in the old days before createResolver ❤️ it just can't be a virtual module

They did in the old days before `createResolver` ❤️ it just can't be a virtual module
Adammatthiesen commented 2024-03-05 09:30:57 +00:00 (Migrated from github.com)
Review

Yeah.... Thats updated now across the board... and those exports for /rss-routes and /open-graph are now moved to resolve()

Yeah.... Thats updated now across the board... and those exports for `/rss-routes` and `/open-graph` are now moved to `resolve()`
}),
plugins: [...corePlugins],
setup({ options }) {

jdtjenkins commented 2024-03-05 08:52:19 +00:00 (Migrated from github.com)
Review

You can probably resolve these paths instead of exporting it from your package?

You can probably resolve these paths instead of exporting it from your package?
jdtjenkins commented 2024-03-05 08:52:19 +00:00 (Migrated from github.com)
Review

You can probably resolve these paths instead of exporting it from your package?

You can probably resolve these paths instead of exporting it from your package?
Adammatthiesen commented 2024-03-05 09:00:35 +00:00 (Migrated from github.com)
Review

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...
Adammatthiesen commented 2024-03-05 09:00:35 +00:00 (Migrated from github.com)
Review

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...

I was told that any Injected route had to be from an export.... I'd be interested in that alternative...
jdtjenkins commented 2024-03-05 09:04:42 +00:00 (Migrated from github.com)
Review

They did in the old days before createResolver ❤️ it just can't be a virtual module

They did in the old days before `createResolver` ❤️ it just can't be a virtual module
jdtjenkins commented 2024-03-05 09:04:42 +00:00 (Migrated from github.com)
Review

They did in the old days before createResolver ❤️ it just can't be a virtual module

They did in the old days before `createResolver` ❤️ it just can't be a virtual module
Adammatthiesen commented 2024-03-05 09:30:57 +00:00 (Migrated from github.com)
Review

Yeah.... Thats updated now across the board... and those exports for /rss-routes and /open-graph are now moved to resolve()

Yeah.... Thats updated now across the board... and those exports for `/rss-routes` and `/open-graph` are now moved to `resolve()`
Adammatthiesen commented 2024-03-05 09:30:57 +00:00 (Migrated from github.com)
Review

Yeah.... Thats updated now across the board... and those exports for /rss-routes and /open-graph are now moved to resolve()

Yeah.... Thats updated now across the board... and those exports for `/rss-routes` and `/open-graph` are now moved to `resolve()`

View File

@ -6,7 +6,7 @@ import c from "picocolors";
export default defineIntegration({
name: "@matthiesenxyz/astro-ghostcms-satoriog",
optionsSchema: z.object({
verbose: z.boolean().optional().default(false),
verbose: z.coerce.boolean().optional(),
}),
plugins: [...corePlugins],
setup({ options }) {

View File

@ -6,16 +6,15 @@ import c from "picocolors";
export default defineIntegration({
name: "@matthiesenxyz/astro-ghostcms-themeprovider",
optionsSchema: z.object({
theme: z
.string()
.optional()
.default("@matthiesenxyz/astro-ghostcms-theme-default"),
verbose: z.boolean().optional().default(false),
theme: z.string(),
verbose: z.coerce.boolean().optional(),
}),
plugins: [...corePlugins],
setup({ options }) {
const { resolve } = createResolver(import.meta.url);
const DEFAULT_THEME = "@matthiesenxyz/astro-ghostcms-theme-default";
return {
"astro:config:setup": ({ watchIntegration, injectRoute, logger }) => {
watchIntegration(resolve());
@ -37,7 +36,7 @@ export default defineIntegration({
);
if (options.theme === "@matthiesenxyz/astro-ghostcms-theme-default") {
if (options.theme === DEFAULT_THEME) {
verboseLogsInfo(
c.blue("No theme is set, injecting default theme"),
);

View File

@ -13,6 +13,7 @@ describe("GhostUserConfigSchema", () => {
enableRSSFeed: true,
enableOGImages: true,
verbose: false,
Integrations: {},
};
const result = GhostUserConfigSchema.safeParse(validConfig);

View File

@ -13,34 +13,38 @@ export const GhostUserConfigSchema = z.object({
* })
* ],
* }); */
ghostURL: z.string().url().optional(),
ghostURL: z.coerce.string().url("Must be a URL").optional(),
/** OPTIONAL - Configure the Theme Provider
* @ This option allows the user to configure the Theme Provider
*/
ThemeProvider: z
.object({
/** OPTIONAL - Disable the theme provider
* @default false
*/
disableThemeProvider: z.boolean().optional().default(false),
disableThemeProvider: z.coerce.boolean(),
/** OPTIONAL - Set the theme you want to use
* @default "@matthiesenxyz/astro-ghostcms-theme-default"
*/
theme: z
.string()
.optional()
.default("@matthiesenxyz/astro-ghostcms-theme-default"),
theme: z.string(),
})
.optional(),
.optional()
.default({
disableThemeProvider: false,
theme: "@matthiesenxyz/astro-ghostcms-theme-default"
}),
/** Allows the user to disable the provided 404 page */
disableDefault404: z.boolean().optional().default(false),
disableDefault404: z.coerce.boolean().optional(),
/** Allows the user to disable the provided RSS Feed */
enableRSSFeed: z.boolean().optional().default(true),
enableRSSFeed: z.coerce.boolean().optional().default(true),
/** Allows the user to Enable or Disable the default Satori OG Image Generation
* @default true
*/
enableOGImages: z.boolean().optional().default(true),
enableOGImages: z.coerce.boolean().optional().default(true),
/** Allows the user to turn on/off Full Console Logs
* @default true
*/
verbose: z.boolean().optional().default(false),
verbose: z.coerce.boolean().optional(),
/** OPTIONAL - Integrations Configuration
* This option allows the user to configure the included integrations
* Options shown are the availble options
@ -60,7 +64,7 @@ export const GhostUserConfigSchema = z.object({
*/
sitemap: z.custom<SitemapOptions>().optional(),
})
.optional(),
.optional().default({}),
});
/** USER CONFIGURATION SCHEMA */

View File

@ -14,7 +14,7 @@ export default defineConfig({
ThemeProvider: {
theme: "@matthiesenxyz/astro-ghostcms-brutalbyelian",
},
verbose: false,
verbose: true,
}),
],
});