Chore: Upgrade to AIK & Massive Overhaul to internal processing #78

Merged
Adammatthiesen merged 46 commits from issue-77-Chore_Upgrade_to_utilize_AIK_&_Massive_integration_overhaul into main 2024-03-07 12:08:19 +00:00
1 changed files with 15 additions and 27 deletions
Showing only changes of commit b1d7a044cf - Show all commits

View File

@ -44,19 +44,18 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Configure Loggers // Configure Loggers
const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));
const loggerTagged = (message: string) => {
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
}
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Configure ENV Logger // Configure ENV Logger
const GhostENVLogger = logger.fork( const GhostENVLogger = loggerTagged("ENV Check");
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
"ENV Check",
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
)}`,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Configure Integration Loggers & verbose logging // Configure Integration Loggers & verbose logging
const GhostIntegrationLogger = logger.fork( const GhostIntegrationLogger = loggerTagged("Integrations");
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
"Integrations", // Configure Route Logger & verbose logging
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
)}`, const GhostRouteLogger = loggerTagged("Router");
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Log Info Helper // Log Info Helper
const intLogInfo = (message:string) => { const intLogInfo = (message:string) => {
@ -65,13 +64,6 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
} }
}; };
// Configure Route Logger & verbose logging
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const GhostRouteLogger = logger.fork(
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
"Router",
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
)}`,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Log Route Info Helper // Log Route Info Helper
const routeLogInfo = (message:string) => { const routeLogInfo = (message:string) => {
if (verbose) { if (verbose) {
@ -241,17 +233,13 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
); );
}, },
"astro:server:start": async ({ logger }) => { "astro:server:start": async ({ logger }) => {
const loggerTagged = (message: string) => {
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.green(message)}`)
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
}
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Configure Loggers // Configure Loggers
const GhostLogger = logger.fork( const GhostLogger = loggerTagged("DEV");
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.bold(
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
c.green("DEV"), const GhostUpdateLogger = loggerTagged("VERSION CHECK");
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
)}`,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const GhostUpdateLogger = logger.fork(
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.bold(
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
c.green("VERSION CHECK"),
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
)}`,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Start the DEV server // Start the DEV server
GhostLogger.info( GhostLogger.info(

florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```