MatthiesenXYZ/astro-ghostcms
MatthiesenXYZ
/
astro-ghostcms
1
0
Fork 0
Code Issues Pull Requests Projects Releases 125 Activity

Chore: Upgrade to AIK & Massive Overhaul to internal processing #78

Merged
Adammatthiesen merged 46 commits from issue-77-Chore_Upgrade_to_utilize_AIK_&_Massive_integration_overhaul into main 2024-03-07 12:08:19 +00:00
Conversation 3 Commits 46 Files Changed 179 +14 -1
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 657cfe7568 - Show all commits

15
packages/astro-ghostcms/README.md
View File

@ -59,7 +59,20 @@ import GhostCMS from '@matthiesenxyz/astro-ghostcms';
// https://astro.build/config // https://astro.build/config
export default defineConfig({ export default defineConfig({
site: "https://YOUR-DOMAIN-HERE.com" site: "https://YOUR-DOMAIN-HERE.com"
integrations: [GhostCMS()], integrations: [
GhostCMS({
// Config Options
ghostURL: "http://example.com"; // Recommended to set here, Can also set in .env as CONTENT_API_URL
disableThemeProvider: false; // OPTIONAL - Default False
ThemeProvider: { // Allows you to pass config options to our ThemeProvider if enabled.
florian-lefebvre commented 2024-03-04 13:13:43 +00:00 (Migrated from github.com)
Review
Copy Link

a matter of preferences i guess but i'd expect any property in the options to follow camelCase

a matter of preferences i guess but i'd expect any property in the options to follow `camelCase`
Adammatthiesen commented 2024-03-04 16:52:40 +00:00 (Migrated from github.com)
Review
Copy Link

"The first letter may or may not be capitalized in CamelCase. This difference is called UpperCamelCase and lowerCamelCase. PascalCase always has the first letter capitalized."

According the camelCase this convention is acceptable. I mainly switched to UpperCamelCase for the Arrays that handle multiple different things, such as the Integations Options that passes through to the internal integrations and the ThemeProvider which is going to become a much bigger internal entity to control how the theme system is going to work, the goal being to expand to more options for being able to add to an already built astro project or use a pre-built.

"The first letter may or may not be capitalized in CamelCase. This difference is called UpperCamelCase and [lowerCamelCase](https://www.techtarget.com/whatis/definition/lowerCamelCase). PascalCase always has the first letter capitalized." According the `camelCase` this convention is acceptable. I mainly switched to UpperCamelCase for the Arrays that handle multiple different things, such as the `Integations` Options that passes through to the internal integrations and the `ThemeProvider` which is going to become a much bigger internal entity to control how the theme system is going to work, the goal being to expand to more options for being able to add to an already built astro project or use a pre-built.
florian-lefebvre commented 2024-03-04 17:07:22 +00:00 (Migrated from github.com)
Review
Copy Link

as i said, only a matter of preferences!

as i said, only a matter of preferences!
theme: "@matthiesenxyz/astro-ghostcms-theme-default"; // OPTIONAL - Default Theme shown.
};
disableDefault404: false; // Allows the user to disable the default `/404 page, to be able to create their own under `/src/pages/404.astro`.
enableRSSFeed: true; // Allows the user to Enable or disable RSS Feed Generation. Default: true
enableOGImages: true; // Allows the user to Enable or disable OG Image Generation. Default: true
fullConsoleLogs: false; // Show the full Log output from All parts of Astro-GhostCMS
})
],
}); });
``` ```