Chore: Upgrade to AIK & Massive Overhaul to internal processing #78

Merged
Adammatthiesen merged 46 commits from issue-77-Chore_Upgrade_to_utilize_AIK_&_Massive_integration_overhaul into main 2024-03-07 12:08:19 +00:00
2 changed files with 31 additions and 14 deletions
Showing only changes of commit 302af0f7b6 - Show all commits

View File

@ -1,26 +1,31 @@
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Node Modules
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import path from "node:path";
import { fileURLToPath } from "node:url";
import fse from "fs-extra";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Utils
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import { createResolver, defineIntegration } from "astro-integration-kit";
import { corePlugins } from "astro-integration-kit/plugins";
import { AstroError } from "astro/errors";
import fse from "fs-extra";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import c from "picocolors";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import { loadEnv } from "vite";
import { GhostUserConfigSchema } from "./schemas/userconfig";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import latestVersion from "./utils/latestVersion";
import c from "picocolors";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Import External Integrations
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// External Integrations
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import sitemap from "@astrojs/sitemap";
import robotsTxt from "astro-robots-txt";
import ghostRSS from "./integrations/rssfeed";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Import Internal Integrations
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Internal Integrations
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import ghostOGImages from "./integrations/satoriog";
import ghostRSS from "./integrations/rssfeed";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import ghostThemeProvider from "./integrations/themeprovider";
// Load environment variables
const ENV = loadEnv("all", process.cwd(), "CONTENT_API");
// Import User Configuration Zod Schema
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
import { GhostUserConfigSchema } from "./schemas/userconfig";
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
/** Astro-GhostCMS Integration
* @description This integration allows you to use GhostCMS as a headless CMS for your Astro project
* @see https://astro-ghostcms.xyz for the most up-to-date documentation!
@ -34,14 +39,11 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
return {
"astro:config:setup": ({
watchIntegration,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
hasIntegration,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
addIntegration,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
addVirtualImports,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
addDts,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
injectRoute,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
logger,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
watchIntegration, hasIntegration, addIntegration,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
addVirtualImports, addDts,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
injectRoute, logger,
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
}) => {
// Configure Loggers
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));
const GhostENVLogger = logger.fork(
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(
@ -59,9 +61,11 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
)}`,
);
// Setup Watch Integration for Hot Reload during DEV
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
watchIntegration(resolve());
GhostLogger.info("Initializing @matthiesenxyz/astro-ghostcms...");
// Set up verbose logging
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const verbose = options.fullConsoleLogs;
// Check for GhostCMS environment variables
@ -72,6 +76,7 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
),
),
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
if (ENV.CONTENT_API_KEY === undefined) {
GhostENVLogger.error(
c.bgRed(
@ -229,16 +234,20 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
});
},
"astro:config:done": ({ logger }) => {
// Configure Loggers
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const GhostLogger = logger.fork(
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.green(
"CONFIG",
)}`,
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Log Configuration Complete
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
GhostLogger.info(
c.bold(c.green("Integration Setup & Configuration Complete")),
);
},
"astro:server:start": async ({ logger }) => {
// Configure Loggers
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const GhostLogger = logger.fork(
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.bold(
c.green("DEV"),
@ -256,14 +265,19 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
);
// Check for updates
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Get the latest version of Astro-GhostCMS
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const currentNPMVersion = await latestVersion(
"@matthiesenxyz/astro-ghostcms",
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Get the local version of Astro-GhostCMS
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const packageJson = await fse.readJson(
path.resolve(fileURLToPath(import.meta.url), "../../package.json"),
);
const localVersion = packageJson.version;
// Log the version check
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
if (currentNPMVersion !== localVersion) {
GhostUpdateLogger.warn(
`\n${c.bgYellow(
@ -292,11 +306,14 @@ export default defineIntegration({
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
}
},
"astro:build:done": ({ logger }) => {
// Configure Loggers
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
const GhostLogger = logger.fork(
`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.bold(
c.green("BUILD"),
)}`,
);
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
// Log Build Complete
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
GhostLogger.info(
c.bold(c.magenta("Running Astro-GhostCMS in Production mode 🚀")),
);

florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:08 +00:00 (Migrated from github.com)
Review
				} else if (verbose) {
					GhostIntegrationLogger.info(c.gray("Theme Provider is disabled"));
				}
```suggestion } else if (verbose) { GhostIntegrationLogger.info(c.gray("Theme Provider is disabled")); } ```
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:25 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:38 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:18:54 +00:00 (Migrated from github.com)
Review

same here

same here
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
florian-lefebvre commented 2024-03-04 13:20:35 +00:00 (Migrated from github.com)
Review

is there a reason for not importing it at the top of the file? if yes, I think you can use resolve from createResolver for the path

is there a reason for not importing it at the top of the file? if yes, I think you can use `resolve` from `createResolver` for the path
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
Adammatthiesen commented 2024-03-04 16:00:44 +00:00 (Migrated from github.com)
Review

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D

This is simply to display any new version during dev-mode only... There is a check for latest version and it compares the local version :D
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
florian-lefebvre commented 2024-03-04 16:13:10 +00:00 (Migrated from github.com)
Review

ah this pulls the version from the user's project?

ah this pulls the version from the user's project?
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
Adammatthiesen commented 2024-03-04 16:57:03 +00:00 (Migrated from github.com)
Review

I ALWAYS FORGET YOU CAN DO else if vscode should complain if you do an else { if() lol

I ALWAYS FORGET YOU CAN DO `else if` vscode should complain if you do an `else { if()` lol
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
florian-lefebvre commented 2024-03-04 17:07:49 +00:00 (Migrated from github.com)
Review

i think if you have eslint you can enable such a rule

i think if you have eslint you can enable such a rule
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
Adammatthiesen commented 2024-03-04 17:16:19 +00:00 (Migrated from github.com)
Review

grabs the current installed one from astro-ghostcms local version and compares to the latestversion from NPM :P I did actually try to use the resolve() util but that just grabbed the playgrounds package.json ironically...

grabs the current installed one from `astro-ghostcms` local version and compares to the latestversion from NPM :P I did actually try to use the `resolve()` util but that just grabbed the playgrounds package.json ironically...
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
jdtjenkins commented 2024-03-04 17:55:58 +00:00 (Migrated from github.com)
Review

Instead of all these manual checks for verbose you'd probably be better off with a util function which checks it instead.

const log = message => {
  if (verbose) {
    console.log(...)
  }
}

Or could be a Florian special and return a console log function:

const createLogger = verbose => message => {
  if (verbose) {
    console.log(...)
  }
}

const log = createLogger(options.verbose)

log(whatever) // now you don't have to check everywhere
Instead of all these manual checks for `verbose` you'd probably be better off with a util function which checks it instead. ```ts const log = message => { if (verbose) { console.log(...) } } ``` Or could be a Florian special and return a console log function: ```ts const createLogger = verbose => message => { if (verbose) { console.log(...) } } const log = createLogger(options.verbose) log(whatever) // now you don't have to check everywhere ```
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 18:25:55 +00:00 (Migrated from github.com)
Review

added in new commit, since im not using console.log had to modify it for my usage a little

added in new commit, since im not using console.log had to modify it for my usage a little
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
Adammatthiesen commented 2024-03-04 20:50:42 +00:00 (Migrated from github.com)
Review

Okay i fixed that issue. Now using resolve() properly 😄

Okay i fixed that issue. Now using `resolve()` properly 😄
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
jdtjenkins commented 2024-03-05 08:46:45 +00:00 (Migrated from github.com)
Review

This logging function could also be extracted

const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`
This logging function could also be extracted ```ts const formattedMessage = message => `${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}` ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```
Adammatthiesen commented 2024-03-05 09:16:09 +00:00 (Migrated from github.com)
Review

Updated...


				// Configure Loggers
				const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS")));

				const loggerTagged = (message: string) => {
					return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`)
				}

				// Configure ENV Logger
				const GhostENVLogger = loggerTagged("ENV Check");

				// Configure Integration Loggers & verbose logging
				const GhostIntegrationLogger = loggerTagged("Integrations");

				// Configure Route Logger & verbose logging
				const GhostRouteLogger = loggerTagged("Router");
Updated... ```ts // Configure Loggers const GhostLogger = logger.fork(c.bold(c.blue("👻 Astro-GhostCMS"))); const loggerTagged = (message: string) => { return logger.fork(`${c.bold(c.blue("👻 Astro-GhostCMS"))}${c.gray("/")}${c.blue(message)}`) } // Configure ENV Logger const GhostENVLogger = loggerTagged("ENV Check"); // Configure Integration Loggers & verbose logging const GhostIntegrationLogger = loggerTagged("Integrations"); // Configure Route Logger & verbose logging const GhostRouteLogger = loggerTagged("Router"); ```

View File

@ -1,3 +1,3 @@
jdtjenkins commented 2024-03-05 08:50:58 +00:00 (Migrated from github.com)
Review

Not a huge fan of this not being camel cased

Not a huge fan of this not being camel cased
jdtjenkins commented 2024-03-05 08:50:58 +00:00 (Migrated from github.com)
Review

Not a huge fan of this not being camel cased

Not a huge fan of this not being camel cased
Adammatthiesen commented 2024-03-05 09:02:16 +00:00 (Migrated from github.com)
Review

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣
Adammatthiesen commented 2024-03-05 09:02:16 +00:00 (Migrated from github.com)
Review

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣
import astroghostcms from "./astro-ghostcms.js";
jdtjenkins commented 2024-03-05 08:50:58 +00:00 (Migrated from github.com)
Review

Not a huge fan of this not being camel cased

Not a huge fan of this not being camel cased
Adammatthiesen commented 2024-03-05 09:02:16 +00:00 (Migrated from github.com)
Review

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣
import astroghostcms from "./astro-ghostcms";
jdtjenkins commented 2024-03-05 08:50:58 +00:00 (Migrated from github.com)
Review

Not a huge fan of this not being camel cased

Not a huge fan of this not being camel cased
Adammatthiesen commented 2024-03-05 09:02:16 +00:00 (Migrated from github.com)
Review

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣
export default astroghostcms;

jdtjenkins commented 2024-03-05 08:50:58 +00:00 (Migrated from github.com)
Review

Not a huge fan of this not being camel cased

Not a huge fan of this not being camel cased
jdtjenkins commented 2024-03-05 08:50:58 +00:00 (Migrated from github.com)
Review

Not a huge fan of this not being camel cased

Not a huge fan of this not being camel cased
Adammatthiesen commented 2024-03-05 09:02:16 +00:00 (Migrated from github.com)
Review

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣
Adammatthiesen commented 2024-03-05 09:02:16 +00:00 (Migrated from github.com)
Review

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣

fixed... idk how that even happened... lol that must have been done by VSCode when i changed the name of the file 🤣